-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force refresh on chunk preload error #7600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice!
Have you managed to test the fresh deployment case? I'm wondering if it will reload and show the new page, or reloads and show the current page again.
It will show the new page because the URL has updated already. I'm waiting for the preview build to complete, then change something to trigger another preview build while having a tab open on the previous preview build. Hopefully I can test it this way. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Nice, I think I've been tricked by this in the past. |
Size Change: +27 B (0%) Total Size: 801 kB ℹ️ View Unchanged
|
hmmm we can give a try but wonder if it will work fine under all conditions For example what if the user has a temporary bad network? We'll see |
We didn't retry before this anyway. Refreshing is already a form of retry, and if it fails, the user instantly knows something is wrong, instead of getting stuck in an infinite loading bar. |
Was about to say something like this but @Josh-Cena said it better |
Pre-flight checklist
Motivation
Fixes #7599
Test Plan
yarn run serve
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs